)]}'
{
  "commit": "e2b3b80e439905ba7be9416a61b55df8da0c698f",
  "tree": "b8f6d6536c466c9feb0f329f14c927acc28e096d",
  "parents": [
    "b4a0eb2d06fa69a29fc0c87758fe294ccf5a7d99"
  ],
  "author": {
    "name": "Mike Frysinger",
    "email": "vapier@chromium.org",
    "time": "Fri Mar 29 14:14:27 2019 -0400"
  },
  "committer": {
    "name": "Mike Frysinger",
    "email": "vapier@chromium.org",
    "time": "Sat Mar 30 03:52:15 2019 +0000"
  },
  "message": "linux_core_dumper: add explicit casts for exception fields\n\nSome of the fields we save might have signed types depending on the\nsystem (e.g. `typedef int pid_t`).  Depending on the toolchain, we\ncan trip -Werror\u003dnarrowing failures like:\nsrc/client/linux/minidump_writer/linux_core_dumper.cc:248:66: error:\n  narrowing conversion of ‘(__pid_t)info-\u003esiginfo_t::_sifields.siginfo_t::\u003canonymous union\u003e::_kill.siginfo_t::\u003canonymous union\u003e::\u003canonymous struct\u003e::si_pid’\n  from ‘__pid_t {aka int}’ to ‘long unsigned int’ inside { } [-Werror\u003dnarrowing]\n             set_crash_exception_info({info-\u003esi_pid, info-\u003esi_uid});\n                                             ^^^^^^\nsrc/client/linux/minidump_writer/linux_core_dumper.cc:252:71: error:\n  narrowing conversion of ‘(int)info-\u003esiginfo_t::_sifields.siginfo_t::\u003canonymous union\u003e::_sigsys.siginfo_t::\u003canonymous union\u003e::\u003canonymous struct\u003e::_syscall’\n  from ‘int’ to ‘long unsigned int’ inside { } [-Werror\u003dnarrowing]\n             set_crash_exception_info({info-\u003esi_syscall, info-\u003esi_arch});\n                                             ^^^^^^^^^^\n\nSince the exception info fields are all uint64_t which should be large\nenough to handle all the fields in the siginfo_t structure, add casts\nfor all the assignments to avoid these errors.  We have implicit casts\neven without them, so we aren\u0027t changing behavior.\n\nBug: google-breakpad:791\nBug: chromium:945653\nChange-Id: Ib04e015998f08b857159ac13e9a065a66d228d49\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1544862\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3b1eabb483d1602a6e6ab9c2c005da6257e23fc9",
      "old_mode": 33188,
      "old_path": "src/client/linux/minidump_writer/linux_core_dumper.cc",
      "new_id": "4150689839aae8524bf176237b2c39f9b4f1c4ba",
      "new_mode": 33188,
      "new_path": "src/client/linux/minidump_writer/linux_core_dumper.cc"
    }
  ]
}