)]}' { "commit": "422c66357c3eb319ef307e4f80dd3bb8f85741cc", "tree": "712bc0d5170d8f2dc28f48863748572bde88b795", "parents": [ "4735946d71ace4263b1ecb39f29517240be23c82" ], "author": { "name": "Marco Vanotti", "email": "mvanotti@google.com", "time": "Wed Mar 13 16:51:28 2019 -0700" }, "committer": { "name": "Marco Vanotti", "email": "mvanotti@google.com", "time": "Sat Aug 17 20:15:12 2019 -0700" }, "message": "[vim2] fix issues with passing entropy to zircon.\n\nThis CL fixes a bunch of small issues that surfaced when we tried to\nport this change to a different board.\n\nChanges:\n\n* Sort includes in alphabetical order.\n* Remove magic constant specifying the size of the kernel entropy\ncmdline string.\n* Fix error in the static_assert checking bounds of the\nCMDLINE_ENTROPY_SIZE (each char would produce 4 bits of entropy instead\nof 8)\n* Add static_assert checking that CMDLINE_ENTROPY_BITS is multiple of\n32, to avoid writing more than we request.\n* Separate the hw_rand_hex into a function that only reads the hw rng\nand another that converts an uint32 into a 8 hex chars.\n* Fix a typo that avoided adding a \u0027\\0\u0027 at the end of the cmdline\nstring.\n* Add a mandatory_memset implementation, and call that instead of\nmemset for clearing the cmdline buffer after adding the zbi cmdline.\n\nTEST\u003dflashed into a vim2 and checked that zircon received the entropy.\nManually verified that the static asserts have the right bounds.\n\nChange-Id: I93a33c48d201572be3a6603c11b381a297459eb0\n", "tree_diff": [ { "type": "modify", "old_id": "00a249d73ff12cff2dc9e1d740cf346c4edc1d28", "old_mode": 33188, "old_path": "board/khadas/kvim2/zircon.c", "new_id": "7f86a9f99a97d33fcb1c92c6e282ae3408b98f56", "new_mode": 33188, "new_path": "board/khadas/kvim2/zircon.c" } ] }