Remove comment originally added by Brian
There were a few issues with this comment. The one that caught my eye
was the duplicated function name (job_record_pack_details_common), then
I dug deeper and there are also other nested functions that should be
listed for completeness.
The amount of code churn that would result from bumping every outer
(or inner) block is excessive and the only benefit is keeping the protocol
version numbers in lockstep. I discussed the issue with him and the consensus
was that it is probably best to simply remove it.
Ticket: 23220
diff --git a/src/slurmctld/job_mgr.c b/src/slurmctld/job_mgr.c
index 8e48d3a..c7675e8 100644
--- a/src/slurmctld/job_mgr.c
+++ b/src/slurmctld/job_mgr.c
@@ -10359,13 +10359,6 @@
assoc_mgr_lock_t locks = { .qos = READ_LOCK };
xassert(!has_qos_lock || verify_assoc_lock(QOS_LOCK, READ_LOCK));
- /*
- * NOTE: There are nested pack blocks in
- * job_record_pack_details_common() and
- * job_record_pack_details_common(). Bump this protocol block when
- * bumping the blocks in these functions to help keep symmetry between
- * pack and unpacks.
- */
if (protocol_version >= SLURM_25_05_PROTOCOL_VERSION) {
job_record_pack_common(dump_job_ptr, false, buffer,
protocol_version);
