commit c3ff3ba28739f111f8ffdb654ff53d020e910927
author Megan Dahl <megan@schedmd.com> Mon Sep 01 09:32:22 2025 -0600
committer Megan Dahl <megan@schedmd.com> Tue Sep 02 16:47:39 2025 -0600
tree 15a89693c14285b1b98e278908f52fb7f33a4878
parent b80cd0f1088d32bf49cc264965fe67b19ac38bc4

Return void from _convert_data_force_bool() since value is not used

Ticket: 23400

src/common/data.c

diff --git a/src/common/data.c b/src/common/data.c
index 0db8954..c822eaa 100644
--- a/src/common/data.c
+++ b/src/common/data.c
@@ -1490,7 +1490,7 @@
 	}
 }
 
-static int _convert_data_force_bool(data_t *data)
+static void _convert_data_force_bool(data_t *data)
 {
 	_check_magic(data);
 
@@ -1502,23 +1502,21 @@
 	case TYPE_STRING_PTR:
 		/* non-empty string but not recognized format */
 		data_set_bool(data, true);
-		return SLURM_SUCCESS;
+		break;
 	case TYPE_BOOL:
-		return SLURM_SUCCESS;
+		break;
 	case TYPE_NULL:
 		data_set_bool(data, false);
-		return SLURM_SUCCESS;
+		break;
 	case TYPE_FLOAT:
 		data_set_bool(data, data->data.float_u != 0);
-		return SLURM_SUCCESS;
+		break;
 	case TYPE_INT_64:
 		data_set_bool(data, data->data.int_u != 0);
-		return SLURM_SUCCESS;
+		break;
 	default:
-		return ESLURM_DATA_CONV_FAILED;
+		break;
 	}
-
-	return ESLURM_DATA_CONV_FAILED;
 }
 
 static int _convert_data_null(data_t *data)
@@ -1891,7 +1889,7 @@
 		_convert_data_string(data);
 		break;
 	case DATA_TYPE_BOOL:
-		(void) _convert_data_force_bool(data);
+		_convert_data_force_bool(data);
 		break;
 	case DATA_TYPE_INT_64:
 		(void) _convert_data_int(data, true);