commit | 5bc3092b30e022b1629d94867e64c9388bc289cf | [log] [tgz] |
---|---|---|
author | Bryan Klimt <klimt@google.com> | Fri Nov 22 10:55:42 2019 -0800 |
committer | Mike Frysinger <vapier@chromium.org> | Wed Dec 04 19:46:05 2019 +0000 |
tree | 590ff59ab0d64af94368eab04c627596e22f73b9 | |
parent | 47cd498384fdf7e54b0c8a6678c8af6a71635d0f [diff] |
Add a variable to allow adding an extra include path for LSS. I have a project where we are trying to include breakpad as a git submodule. The only problem getting it to build with ndk-build is that the linux_syscall_support.h header is missing. Normally, this header would be downloaded by the depot_tools. But we cannot install depot_tools on our CI machines. So, we would like to include the header as a separate submodule in our repo. The only change we would need to make to breakpad to make that work is to add this optional variable to the C header search path. In the normal case, this variable will not be set and nothing will be different. But we can set the variable to allow us to build without installing depot_tools. I have manually tested this using a separate project that links to breakpad in this way. Change-Id: Id116b2af1c1ba0a08464c213d8982b24a1821ee7 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1930179 Reviewed-by: Mark Mentovai <mark@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH
.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch
tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk
, src/processor/minidump_dump
, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms
, src/tools/linux/md2core/minidump-2-core
, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean
first.
To update an existing checkout to a newer revision, you can git pull
as usual, but then you should run gclient sync
to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ...
You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.