fix write() unused-result warning
src/client/linux/microdump_writer/microdump_writer_unittest.cc:98:47: error:
ignoring return value of 'ssize_t write(int, const void*, size_t)',
declared with attribute warn_unused_result [-Werror=unused-result]
write(STDOUT_FILENO, identifiable_string, 0);
Change-Id: I3f2305fbec0dbd1464de9aeff051e7cba2ee69a2
Reviewed-on: https://chromium-review.googlesource.com/438545
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
diff --git a/src/client/linux/microdump_writer/microdump_writer_unittest.cc b/src/client/linux/microdump_writer/microdump_writer_unittest.cc
index e5e6f44..cbcd139 100644
--- a/src/client/linux/microdump_writer/microdump_writer_unittest.cc
+++ b/src/client/linux/microdump_writer/microdump_writer_unittest.cc
@@ -95,7 +95,7 @@
// has been sanitized.
strcpy(identifiable_string, kIdentifiableString);
// Force the strcpy to not be optimized away.
- write(STDOUT_FILENO, identifiable_string, 0);
+ IGNORE_RET(write(STDOUT_FILENO, identifiable_string, 0));
const pid_t child = fork();
if (child == 0) {
diff --git a/src/client/mac/tests/exception_handler_test.cc b/src/client/mac/tests/exception_handler_test.cc
index a8cf696..d5b505a 100644
--- a/src/client/mac/tests/exception_handler_test.cc
+++ b/src/client/mac/tests/exception_handler_test.cc
@@ -36,6 +36,7 @@
#include "breakpad_googletest_includes.h"
#include "client/mac/handler/exception_handler.h"
+#include "common/linux/ignore_ret.h"
#include "common/mac/MachIPC.h"
#include "common/tests/auto_tempdir.h"
#include "google_breakpad/processor/minidump.h"
@@ -93,7 +94,7 @@
path.append(".dmp");
int fd = *reinterpret_cast<int*>(context);
- (void)write(fd, path.c_str(), path.length() + 1);
+ IGNORE_RET(write(fd, path.c_str(), path.length() + 1));
close(fd);
exit(0);
// not reached
@@ -293,7 +294,7 @@
// Unblock child process
uint8_t data = 1;
- (void)write(fds[1], &data, 1);
+ IGNORE_RET(write(fds[1], &data, 1));
// Child process should have exited with a zero status.
int ret;
diff --git a/src/client/mac/tests/minidump_generator_test.cc b/src/client/mac/tests/minidump_generator_test.cc
index d40c7d9..b1fa5d0 100644
--- a/src/client/mac/tests/minidump_generator_test.cc
+++ b/src/client/mac/tests/minidump_generator_test.cc
@@ -42,6 +42,7 @@
#include "breakpad_googletest_includes.h"
#include "client/mac/handler/minidump_generator.h"
#include "client/mac/tests/spawn_child_process.h"
+#include "common/linux/ignore_ret.h"
#include "common/mac/MachIPC.h"
#include "common/tests/auto_tempdir.h"
#include "google_breakpad/processor/minidump.h"
@@ -190,7 +191,7 @@
// Unblock child process
uint8_t data = 1;
- (void)write(fds[1], &data, 1);
+ IGNORE_RET(write(fds[1], &data, 1));
// Child process should have exited with a zero status.
int ret;
