libibmad: encode SM_Key in SA MAD headers

mad_encode() always encodes rpc->mkey in IB_MAD_MKEY_F. For an SA MAD,
that location is part of the RMPP header; the SA SM_Key is stored later
in IB_SA_MKEY_F.

This was harmless for existing SA users because rpc->mkey was always
zero. Code requiring a nonzero key instead had to build the packet and
patch IB_SA_MKEY_F afterward.

Encode rpc->mkey according to the management class, using
IB_SA_MKEY_F for SA MADs and retaining IB_MAD_MKEY_F for other
classes. Reusing rpc->mkey avoids extending the public ib_rpc_t
structure and treats it as the generic management-key value for the
selected class.

Update sa_query() to set rpc.mkey before building the packet instead of
patching the encoded SA MAD directly.

Signed-off-by: Jonathan Süssemilch Poulain <jpoulain@coreweave.com>
2 files changed
tree: 6256a2914f0e7f843d2ba527067ee6fe70b27d6b
  1. buildlib/
  2. ccan/
  3. debian/
  4. Documentation/
  5. ibacm/
  6. infiniband-diags/
  7. iwpmd/
  8. kernel-boot/
  9. kernel-headers/
  10. libibmad/
  11. libibnetdisc/
  12. libibumad/
  13. libibverbs/
  14. librdmacm/
  15. providers/
  16. pyverbs/
  17. rdma-ndd/
  18. redhat/
  19. srp_daemon/
  20. suse/
  21. tests/
  22. util/
  23. .clang-format
  24. .gitignore
  25. .mailmap
  26. build.sh
  27. CMakeLists.txt
  28. COPYING.BSD_FB
  29. COPYING.BSD_MIT
  30. COPYING.GPL2
  31. COPYING.md
  32. MAINTAINERS
  33. rdma-sysusers.conf
  34. README.md
README.md

Build Status

RDMA Core Userspace Libraries and Daemons

This is the userspace components for the Linux Kernel's drivers/infiniband subsystem. Specifically this contains the userspace libraries for the following device nodes:

  • /dev/infiniband/uverbsX (libibverbs)
  • /dev/infiniband/rdma_cm (librdmacm)
  • /dev/infiniband/umadX (libibumad)

The userspace component of the libibverbs RDMA kernel drivers are included under the providers/ directory. Support for the following Kernel RDMA drivers is included:

  • bnxt_re.ko
  • efa.ko
  • erdma.ko
  • iw_cxgb4.ko
  • hfi1.ko
  • hns-roce-hw-v2.ko
  • ionic_rdma.ko
  • irdma.ko
  • ib_qib.ko
  • mana_ib.ko
  • mlx4_ib.ko
  • mlx5_ib.ko
  • ib_mthca.ko
  • ocrdma.ko
  • qedr.ko
  • rdma_rxe.ko
  • siw.ko
  • vmw_pvrdma.ko

Additional service daemons are provided for:

  • srp_daemon (ib_srp.ko)
  • iwpmd (for iwarp kernel providers)
  • ibacm (for InfiniBand communication management assistant)

Building

This project uses a cmake based build system. Quick start:

$ bash build.sh

build/bin will contain the sample programs and build/lib will contain the shared libraries. The build is configured to run all the programs ‘in-place’ and cannot be installed.

Debian Derived

$ apt-get install build-essential cmake gcc libudev-dev libnl-3-dev libnl-route-3-dev ninja-build pkg-config valgrind python3-dev cython3 python3-docutils pandoc

Supported releases:

  • Debian 9 (stretch) or newer
  • Ubuntu 16.04 LTS (xenial) or newer

Fedora, CentOS 8

$ dnf builddep redhat/rdma-core.spec

NOTE: Fedora Core uses the name ‘ninja-build’ for the ‘ninja’ command.

openSUSE

$ zypper install cmake gcc libnl3-devel libudev-devel ninja pkg-config valgrind-devel python3-devel python3-Cython python3-docutils pandoc

Building on CentOS 7, Amazon Linux 2

Install required packages:

$ yum install cmake gcc libnl3-devel libudev-devel make pkgconfig valgrind-devel

Developers on CentOS 7 or Amazon Linux 2 are suggested to install more modern tooling for the best experience.

CentOS 7:

$ yum install epel-release
$ yum install cmake3 ninja-build pandoc

Amazon Linux 2:

$ amazon-linux-extras install epel
$ yum install cmake3 ninja-build pandoc

NOTE: EPEL uses the name ‘ninja-build’ for the ‘ninja’ command, and ‘cmake3’ for the ‘cmake’ command.

Usage

To set up software RDMA on an existing interface with either of the available drivers, use the following commands, substituting <DRIVER> with the name of the driver of your choice (rdma_rxe or siw) and <TYPE> with the type corresponding to the driver (rxe or siw).

# modprobe <DRIVER>
# rdma link add <NAME> type <TYPE> netdev <DEVICE>

Please note that you need version of iproute2 recent enough is required for the command above to work.

You can use either ibv_devices or rdma link to verify that the device was successfully added.

Reporting bugs

Bugs should be reported to the linux-rdma@vger.kernel.org mailing list In your bug report, please include:

  • Information about your system:

    • Linux distribution and version
    • Linux kernel and version
    • InfiniBand hardware and firmware version
    • ... any other relevant information
  • How to reproduce the bug.

  • If the bug is a crash, the exact output printed out when the crash occurred, including any kernel messages produced.

Submitting patches

See Contributing to rdma-core.

Stable branches

Stable versions are released regularly with backported fixes (see Documentation/stable.md) The current minimum version still maintained is ‘v33.X’