commit 3d8daa2c7458c8e411e691ac6f0d503418ef6231
author Nelson Billing <nbilling@google.com> Wed Aug 05 11:49:07 2020 -0700
committer Nelson Billing <nbilling@google.com> Wed Aug 05 19:42:38 2020 +0000
tree 527c1cc9cec5920ce709102e4be226381df00c1c
parent a6218eb66d7b4880825168a83e66bfea746908a6

Fix sym-upload-v2 whitespace in filenames.

- Checking symbol status would fail for files whose names contained spaces, because the file name was being put in the URL unescaped.
- Now the filename is escaped before being put in URL when checking symbol status.

Change-Id: I3b989d877e0fd9aef57ec13bdbbb6c3dacb6a9e2
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2339782
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>

src/common/mac/SymbolCollectorClient.m

diff --git a/src/common/mac/SymbolCollectorClient.m b/src/common/mac/SymbolCollectorClient.m
index b997607..70f511f 100644
--- a/src/common/mac/SymbolCollectorClient.m
+++ b/src/common/mac/SymbolCollectorClient.m
@@ -70,11 +70,16 @@
                                withAPIKey:(NSString*)APIKey
                             withDebugFile:(NSString*)debugFile
                               withDebugID:(NSString*)debugID {
+  NSString* escapedDebugFile =
+      [debugFile stringByAddingPercentEncodingWithAllowedCharacters:
+                     [NSCharacterSet URLHostAllowedCharacterSet]];
+
   NSURL* URL = [NSURL
       URLWithString:[NSString
                         stringWithFormat:@"%@/v1/symbols/%@/%@:checkStatus"
                                          @"?key=%@",
-                                         APIURL, debugFile, debugID, APIKey]];
+                                         APIURL, escapedDebugFile, debugID,
+                                         APIKey]];
 
   HTTPGetRequest* getRequest = [[HTTPGetRequest alloc] initWithURL:URL];
   NSError* error = nil;