| commit | b2831dbed17a506eda8228ab1a0ecff70af56e9d | [log] [tgz] |
|---|---|---|
| author | John Z Wu <jzw@chromium.org> | Mon May 13 13:11:05 2019 -0700 |
| committer | Mark Mentovai <mark@chromium.org> | Mon May 13 20:24:15 2019 +0000 |
| tree | 430c07e9efc8b0ede7a7697f972a694caa0fd890 | |
| parent | 21b48a72aa50dde84149267f6b7402522b846b24 [diff] |
Increase timeout of HTTPMultipartUpload from 10s to 60s. This, hopefully, will reduce occurrences of UnfinishedReportUploads. It will not eliminate it completely because uploads are never retried if they fail. 60s is actually the default value. Before iOS6, 240s was the default and minimum applied to requests with a body. Reference: https://developer.apple.com/documentation/foundation/nsmutableurlrequest/1414063-timeoutinterval?language=objc Bug:850379 Change-Id: I2f16fda7d7e8cbb8b8a6fc917111d9f646fbdad0 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1609876 Reviewed-by: Mark Mentovai <mark@chromium.org>
diff --git a/src/common/mac/HTTPMultipartUpload.m b/src/common/mac/HTTPMultipartUpload.m index f6d081e..a3677f2 100644 --- a/src/common/mac/HTTPMultipartUpload.m +++ b/src/common/mac/HTTPMultipartUpload.m
@@ -203,7 +203,7 @@ NSMutableURLRequest *req = [[NSMutableURLRequest alloc] initWithURL:url_ cachePolicy:NSURLRequestUseProtocolCachePolicy - timeoutInterval:10.0 ]; + timeoutInterval:60.0]; NSMutableData *postBody = [NSMutableData data];