| /* | |
| * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. | |
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | |
| * | |
| * This code is free software; you can redistribute it and/or modify it | |
| * under the terms of the GNU General Public License version 2 only, as | |
| * published by the Free Software Foundation. | |
| * | |
| * This code is distributed in the hope that it will be useful, but WITHOUT | |
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| * version 2 for more details (a copy is included in the LICENSE file that | |
| * accompanied this code). | |
| * | |
| * You should have received a copy of the GNU General Public License version | |
| * 2 along with this work; if not, write to the Free Software Foundation, | |
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| * | |
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | |
| * or visit www.oracle.com if you need additional information or have any | |
| * questions. | |
| */ | |
| /** | |
| * @test | |
| * @summary simple tests of module provides | |
| * @bug 8168854 8172807 | |
| * @library /tools/lib | |
| * @modules | |
| * jdk.compiler/com.sun.tools.javac.api | |
| * jdk.compiler/com.sun.tools.javac.main | |
| * @build toolbox.ToolBox toolbox.JavacTask ModuleTestBase | |
| * @run main ProvidesTest | |
| */ | |
| import java.nio.file.Files; | |
| import java.nio.file.Path; | |
| import java.util.Arrays; | |
| import java.util.List; | |
| import toolbox.JavacTask; | |
| import toolbox.Task; | |
| import toolbox.Task.Expect; | |
| public class ProvidesTest extends ModuleTestBase { | |
| public static void main(String... args) throws Exception { | |
| ProvidesTest t = new ProvidesTest(); | |
| t.runTests(); | |
| } | |
| @Test | |
| public void testSimple(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { }"); | |
| Path classes = base.resolve("classes"); | |
| Files.createDirectories(classes); | |
| new JavacTask(tb) | |
| .outdir(classes) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testMulti(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src.resolve("m1x"), | |
| "module m1x { exports p1; }", | |
| "package p1; public class C1 { }"); | |
| tb.writeJavaFiles(src.resolve("m2x"), | |
| "module m2x { requires m1x; provides p1.C1 with p2.C2; }", | |
| "package p2; public class C2 extends p1.C1 { }"); | |
| Path modules = base.resolve("modules"); | |
| Files.createDirectories(modules); | |
| new JavacTask(tb) | |
| .options("--module-source-path", src.toString()) | |
| .outdir(modules) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testMissingWith(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.C; }", | |
| "package p; public class C { }"); | |
| Path classes = base.resolve("classes"); | |
| Files.createDirectories(classes); | |
| String log = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(classes) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutput(Task.OutputKind.DIRECT); | |
| if (!log.contains("module-info.java:1:24: compiler.err.expected.str: 'with'")) | |
| throw new Exception("expected output not found"); | |
| } | |
| @Test | |
| public void testDuplicateImplementations1(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { exports p1; exports p2; provides p1.C1 with p2.C2, p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { }"); | |
| Path classes = base.resolve("classes"); | |
| Files.createDirectories(classes); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(classes) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:65: compiler.err.duplicate.provides: p1.C1, p2.C2", | |
| "1 error"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testDuplicateImplementations2(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { exports p1; provides p1.C1 with p2.C2; provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { }"); | |
| Path classes = base.resolve("classes"); | |
| Files.createDirectories(classes); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(classes) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:62: compiler.err.repeated.provides.for.service: p1.C1", | |
| "module-info.java:1:73: compiler.err.duplicate.provides: p1.C1, p2.C2", | |
| "2 errors"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testMissingService(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.Missing with p.C; }", | |
| "package p; public class C extends p.Missing { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "C.java:1:36: compiler.err.cant.resolve.location: kindname.class, Missing, , , (compiler.misc.location: kindname.package, p, null)", | |
| "module-info.java:1:22: compiler.err.cant.resolve.location: kindname.class, Missing, , , (compiler.misc.location: kindname.package, p, null)", | |
| "2 errors"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testProvidesFromAnotherModule(Path base) throws Exception { | |
| Path modules = base.resolve("modules"); | |
| tb.writeJavaFiles(modules.resolve("M"), | |
| "module M { exports p; }", | |
| "package p; public class Service { }"); | |
| tb.writeJavaFiles(modules.resolve("L"), | |
| "module L { requires M; provides p.Service with p.Service; }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics", | |
| "--module-source-path", modules.toString()) | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(modules)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:24: compiler.err.service.implementation.not.in.right.module: M", | |
| "1 error"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testServiceIsNotImplemented(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.A with p.B; }", | |
| "package p; public class A { }", | |
| "package p; public class B { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:31: compiler.err.service.implementation.must.be.subtype.of.service.interface", | |
| "module-info.java:1:12: compiler.warn.service.provided.but.not.exported.or.used: p.A", | |
| "1 error", | |
| "1 warning"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testMissingImplementation(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.C with p.Impl; }", | |
| "package p; public class C { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList("module-info.java:1:31: compiler.err.cant.resolve.location: kindname.class, Impl, , , (compiler.misc.location: kindname.package, p, null)", | |
| "1 error"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testSeveralImplementations(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.C with p.Impl1, p.Impl2; }", | |
| "package p; public class C { }", | |
| "package p; public class Impl1 extends p.C { }", | |
| "package p; public class Impl2 extends p.C { }"); | |
| new JavacTask(tb) | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testRepeatedProvides(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { exports p; provides p.C with p.Impl1; provides p.C with p.Impl2; }", | |
| "package p; public class C { }", | |
| "package p; public class Impl1 extends p.C { }", | |
| "package p; public class Impl2 extends p.C { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList("module-info.java:1:60: compiler.err.repeated.provides.for.service: p.C", | |
| "1 error"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testOneImplementationsForServices(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p.Service1 with p.Impl; provides p.Service2 with p.Impl; }", | |
| "package p; public interface Service1 { }", | |
| "package p; public abstract class Service2 { }", | |
| "package p; public class Impl extends p.Service2 implements p.Service1 { }"); | |
| new JavacTask(tb) | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testAbstractImplementation(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public abstract class C2 extends p1.C1 { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:34: compiler.err.service.implementation.is.abstract: p2.C2"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testInterfaceImplementation(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.Service with p2.Impl; }", | |
| "package p1; public interface Service { }", | |
| "package p2; public interface Impl extends p1.Service { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:39: compiler.err.service.implementation.is.abstract: p2.Impl"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testProtectedImplementation(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; class C2 extends p1.C1 { }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList("module-info.java:1:34: compiler.err.not.def.public: p2.C2, p2", | |
| "1 error"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testNoNoArgConstructor(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { uses p1.C1; provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { public C2(String str) { } }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:46: compiler.err.service.implementation.doesnt.have.a.no.args.constructor: p2.C2"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testPrivateNoArgConstructor(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { uses p1.C1; provides p1.C1 with p2.C2; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { private C2() { } }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:46: compiler.err.service.implementation.no.args.constructor.not.public: p2.C2"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testServiceIndirectlyImplemented(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1 with p2.C3; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 extends p1.C1 { }", | |
| "package p2; public class C3 extends p2.C2 { }"); | |
| new JavacTask(tb) | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testServiceImplementationInnerClass(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1 with p2.C2.Inner; }", | |
| "package p1; public class C1 { }", | |
| "package p2; public class C2 { public class Inner extends p1.C1 { } }"); | |
| List<String> output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| List<String> expected = Arrays.asList( | |
| "module-info.java:1:37: compiler.err.service.implementation.is.inner: p2.C2.Inner"); | |
| if (!output.containsAll(expected)) { | |
| throw new Exception("Expected output not found"); | |
| } | |
| } | |
| @Test | |
| public void testServiceDefinitionInnerClass(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { provides p1.C1.InnerDefinition with p2.C2; }", | |
| "package p1; public class C1 { public class InnerDefinition { } }", | |
| "package p2; public class C2 extends p1.C1.InnerDefinition { public C2() { new p1.C1().super(); } }"); | |
| new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Expect.SUCCESS) | |
| .writeAll(); | |
| } | |
| @Test | |
| public void testFactory(Path base) throws Exception { | |
| Path src = base.resolve("src"); | |
| tb.writeJavaFiles(src, | |
| "module m { exports p1; provides p1.C1 with p2.C2; }", | |
| "package p1; public interface C1 { }", | |
| "package p2; public class C2 { public static p1.C1 provider() { return null; } }"); | |
| new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run() | |
| .writeAll() | |
| .getOutput(Task.OutputKind.DIRECT); | |
| List<String> output; | |
| List<String> expected; | |
| tb.writeJavaFiles(src, | |
| "package p2; public class C2 { public p1.C1 provider() { return null; } }"); | |
| output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| expected = Arrays.asList("module-info.java:1:46: compiler.err.service.implementation.must.be.subtype.of.service.interface", | |
| "1 error"); | |
| if (!expected.equals(output)) { | |
| throw new Exception("Expected output not found. Output: " + output); | |
| } | |
| tb.writeJavaFiles(src, | |
| "package p2; public class C2 { static p1.C1 provider() { return null; } }"); | |
| output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| expected = Arrays.asList("module-info.java:1:46: compiler.err.service.implementation.must.be.subtype.of.service.interface", | |
| "1 error"); | |
| if (!expected.equals(output)) { | |
| throw new Exception("Expected output not found. Output: " + output); | |
| } | |
| tb.writeJavaFiles(src, | |
| "package p2; public class C2 { public static Object provider() { return null; } }"); | |
| output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| expected = Arrays.asList("module-info.java:1:46: compiler.err.service.implementation.provider.return.must.be.subtype.of.service.interface", | |
| "1 error"); | |
| if (!expected.equals(output)) { | |
| throw new Exception("Expected output not found. Output: " + output); | |
| } | |
| tb.writeJavaFiles(src, | |
| "package p2; public class C2 { public static p1.C1 provider = new p1.C1() {}; }"); | |
| output = new JavacTask(tb) | |
| .options("-XDrawDiagnostics") | |
| .outdir(Files.createDirectories(base.resolve("classes"))) | |
| .files(findJavaFiles(src)) | |
| .run(Task.Expect.FAIL) | |
| .writeAll() | |
| .getOutputLines(Task.OutputKind.DIRECT); | |
| expected = Arrays.asList("module-info.java:1:46: compiler.err.service.implementation.must.be.subtype.of.service.interface", | |
| "1 error"); | |
| if (!expected.equals(output)) { | |
| throw new Exception("Expected output not found. Output: " + output); | |
| } | |
| } | |
| } |