blob: 9a1ba3619219e79ca1670b12a0c0a3db6864b293 [file] [log] [blame]
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import sys
def _RunArgs(args, input_api):
p = input_api.subprocess.Popen(args, stdout=input_api.subprocess.PIPE,
stderr=input_api.subprocess.STDOUT)
out, _ = p.communicate()
return (out, p.returncode)
def _CheckRegisteredMetrics(input_api, output_api):
""" Check that all tracing metrics are imported in all_metrics.html """
results = []
tracing_dir = input_api.PresubmitLocalPath()
out, return_code = _RunArgs(
[input_api.python_executable,
input_api.os_path.join(tracing_dir, 'bin', 'validate_all_metrics')],
input_api)
if return_code:
results.append(output_api.PresubmitError(
'Failed validate_all_metrics: ', long_text=out))
return results
def _CheckRegisteredDiagnostics(input_api, output_api):
"""Check that all Diagnostic subclasses are registered."""
results = []
tracing_dir = input_api.PresubmitLocalPath()
out, return_code = _RunArgs(
[input_api.python_executable,
input_api.os_path.join(tracing_dir, 'bin', 'validate_all_diagnostics')],
input_api)
if return_code:
results.append(output_api.PresubmitError(
'Failed validate_all_diagnostics: ', long_text=out))
return results
def CheckChangeOnUpload(input_api, output_api):
return _CheckChange(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _CheckChange(input_api, output_api)
def _CheckChange(input_api, output_api):
results = []
original_sys_path = sys.path
try:
sys.path += [input_api.PresubmitLocalPath()]
from tracing_build import check_gni
error = check_gni.GniCheck()
if error:
results.append(output_api.PresubmitError(error))
finally:
sys.path = original_sys_path
results += input_api.RunTests(input_api.canned_checks.GetPylint(
input_api, output_api, extra_paths_list=_GetPathsToPrepend(input_api),
pylintrc='../pylintrc'))
results += _CheckRegisteredMetrics(input_api, output_api)
results += _CheckRegisteredDiagnostics(input_api, output_api)
return results
def _GetPathsToPrepend(input_api):
import tracing_project
project_dir = input_api.PresubmitLocalPath()
catapult_dir = input_api.os_path.join(project_dir, '..')
return [
project_dir,
input_api.os_path.join(catapult_dir, 'third_party', 'mock'),
] + tracing_project.GetDependencyPaths()